Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ReadingSet has inconsistent mCount / m_readings #862

Open
jchabod opened this issue Oct 27, 2022 · 0 comments
Open

ReadingSet has inconsistent mCount / m_readings #862

jchabod opened this issue Oct 27, 2022 · 0 comments
Assignees
@MarkRiddoch

Comments

@jchabod
Copy link

jchabod commented Oct 27, 2022 •
edited
Loading

ReadingSet class handles inconsistently the fileds mCount towards m_readings.

For example removeAll does not update mCount, which is inconsistent with constructor with a vector of Reading*.

I also am not really sure that the actual meaning of getCount() is supposed to be... This should be documented (cases where this is releveant or not)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MarkRiddoch MarkRiddoch

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@MarkRiddoch @jchabod