-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
https://github.com/WasmEdge/WasmEdge/pull/2659 #18
Comments
Hello, I am a code review bot on flows.network. Here are my reviews of changed source code files in this PR. test/spec/CMakeLists.txtThe provided code in general looks well-structured and following good coding practices for a CMake file. Below are a few notes:
Remember that these comments are based purely on standard good practices and may not apply depending on the specifics of the project, the development environment, and the team's coding conventions. The patch summarises some key changes in the code:
These changes primarily reflect a decision to change the JSON library in use from RapidJSON to SIMDJSON, with a number of necessary adjustments throughout the code to ensure compatibility. test/spec/spectest.cppHere are some potential issues that I found:
Additionally, it would be recommended to follow a consistent curly braces {} style for conditional and control structures. In this piece of code, sometimes they're on the same line and sometimes on a new line. This patch appears to modify a software testing file and includes several significant changes. The updates include:
The "RunCommand" function is updated to read commands differently as simdjson returns a std::string_view+simdjson::dom::object instead of a rapidjson object. In general, the patch seems to be part of a broader refactoring effort aimed at transition from rapidjson to simdjson for JSON processing. |
No description provided.
The text was updated successfully, but these errors were encountered: