From 63b057768402a6d0fd20f0b1122b4cb455ace8df Mon Sep 17 00:00:00 2001 From: Wesley Pettit Date: Sun, 6 Sep 2020 15:51:35 -0700 Subject: [PATCH] aws: utils: fix mem leak in flb_imds_request (#2532) Signed-off-by: Wesley Pettit --- src/aws/flb_aws_util.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/src/aws/flb_aws_util.c b/src/aws/flb_aws_util.c index e92cb62f4ed..b2c20dc99e4 100644 --- a/src/aws/flb_aws_util.c +++ b/src/aws/flb_aws_util.c @@ -444,6 +444,7 @@ int flb_imds_request(struct flb_aws_client *client, char *metadata_path, if (!ec2_metadata) { flb_errno(); + flb_http_client_destroy(c); return -1; } *metadata = ec2_metadata; @@ -452,9 +453,9 @@ int flb_imds_request(struct flb_aws_client *client, char *metadata_path, flb_http_client_destroy(c); return 0; } - else { - flb_debug("[ecs_imds] IMDS metadata response was empty"); - flb_http_client_destroy(c); - return -1; - } + + flb_debug("[ecs_imds] IMDS metadata response was empty"); + flb_http_client_destroy(c); + return -1; + }