From 0e329aa73b35fe9135e783cb1a64cb907aa1f8ca Mon Sep 17 00:00:00 2001 From: Kenzie Schmoll Date: Thu, 5 Sep 2024 12:21:29 -0700 Subject: [PATCH] Try disable GPU --- .../lib/src/test/integration_test_runner.dart | 4 +++- tool/ci/bots.sh | 6 +++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/packages/devtools_shared/lib/src/test/integration_test_runner.dart b/packages/devtools_shared/lib/src/test/integration_test_runner.dart index f88bbdcd500..67e3db01610 100644 --- a/packages/devtools_shared/lib/src/test/integration_test_runner.dart +++ b/packages/devtools_shared/lib/src/test/integration_test_runner.dart @@ -48,8 +48,10 @@ class IntegrationTestRunner with IOMixin { '--target=$testTarget', '-d', headless ? 'web-server' : 'chrome', + // --disable-gpu speeds up tests that use ChromeDriver when run on + // GitHub Actions. See https://github.com/flutter/devtools/issues/8301. + '--web-browser-flag=--disable-gpu', for (final arg in dartDefineArgs) '--dart-define=$arg', - '--browser-dimension=4000,4000', ]; debugLog('> flutter ${flutterDriveArgs.join(' ')}'); final process = await Process.start('flutter', flutterDriveArgs); diff --git a/tool/ci/bots.sh b/tool/ci/bots.sh index 91003971659..0bbbb1df6d7 100755 --- a/tool/ci/bots.sh +++ b/tool/ci/bots.sh @@ -84,11 +84,11 @@ completed). Download these goldens and update them in the codebase to apply the # TODO(https://github.com/flutter/devtools/issues/8301): run these tests with the # --headless flag once the issue with Chrome and chromedriver is resolved. if [ "$DEVICE" = "flutter" ]; then - dart run integration_test/run_tests.dart --shard="$SHARD" + dart run integration_test/run_tests.dart --headless --shard="$SHARD" elif [ "$DEVICE" = "flutter-web" ]; then - dart run integration_test/run_tests.dart --test-app-device=chrome --shard="$SHARD" + dart run integration_test/run_tests.dart --headless --test-app-device=chrome --shard="$SHARD" elif [ "$DEVICE" = "dart-cli" ]; then - dart run integration_test/run_tests.dart --test-app-device=cli --shard="$SHARD" + dart run integration_test/run_tests.dart --headless --test-app-device=cli --shard="$SHARD" fi elif [ "$DEVTOOLS_PACKAGE" = "devtools_extensions" ]; then pushd $DEVTOOLS_DIR/packages/devtools_extensions