From 3bf9c4d57efb7dcee7558cadda81fdb427c4d8b3 Mon Sep 17 00:00:00 2001 From: Derek Xu Date: Wed, 4 Sep 2024 15:18:09 -0400 Subject: [PATCH] Account for the optional parameters that will be added in package:vm_service 14.3.0 This is needed to land the SDK CL that checks in package:vm_service 14.3.0, because this is needed to make the g3-cbuild-try job pass. --- .../devtools_app/lib/src/service/vm_service_wrapper.dart | 1 + .../lib/src/mocks/fake_vm_service_wrapper.dart | 7 ++++++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/packages/devtools_app/lib/src/service/vm_service_wrapper.dart b/packages/devtools_app/lib/src/service/vm_service_wrapper.dart index 34cff683ccb..d0aa6301cb8 100644 --- a/packages/devtools_app/lib/src/service/vm_service_wrapper.dart +++ b/packages/devtools_app/lib/src/service/vm_service_wrapper.dart @@ -153,6 +153,7 @@ class VmServiceWrapper extends VmService { String objectId, { int? offset, int? count, + String? idZoneId, }) { final cachedObj = fakeServiceCache.getObject( objectId: objectId, diff --git a/packages/devtools_test/lib/src/mocks/fake_vm_service_wrapper.dart b/packages/devtools_test/lib/src/mocks/fake_vm_service_wrapper.dart index d67c865a6e8..3be3a388145 100644 --- a/packages/devtools_test/lib/src/mocks/fake_vm_service_wrapper.dart +++ b/packages/devtools_test/lib/src/mocks/fake_vm_service_wrapper.dart @@ -272,6 +272,7 @@ class FakeVmServiceWrapper extends Fake implements VmServiceWrapper { String objectId, { int? offset, int? count, + String? idZoneId, }) { return Future.value(MockObj()); } @@ -298,7 +299,11 @@ class FakeVmServiceWrapper extends Fake implements VmServiceWrapper { } @override - Future getStack(String isolateId, {int? limit}) { + Future getStack( + String isolateId, { + int? limit, + String? idZoneId, + }) { return Future.value(Stack(frames: [], messages: [], truncated: false)); }