Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix envtest setup and usage #2273

Closed
8 tasks done
aryan9600 opened this issue Jan 11, 2022 · 3 comments
Closed
8 tasks done

Fix envtest setup and usage #2273

aryan9600 opened this issue Jan 11, 2022 · 3 comments
Assignees
Labels
area/ci CI related issues and pull requests

Comments

@aryan9600
Copy link
Member

aryan9600 commented Jan 11, 2022

We currently have a a target setup-envtest which installs the etcd, kubectl , etc for users but we don’t use it implicitly in the test target. We also don't seem to set the KUBEBUILDER_ASSETS env to the dir where the binaries are installed so that they can be found during tests.

Projects:

  • flux2
  • pkg
  • source-controller
  • image-automation-controller
  • image-reflector-controller
  • notification-controller
  • source-watcher
  • kustomize-controller
@stefanprodan
Copy link
Member

Please use https://github.com/fluxcd/helm-controller/blob/main/Makefile as an example for all others. Note that testbin must be added to gitignore. Also go get has been deprecated for binaries, we should use go install starting with Go 1.17.

@stefanprodan
Copy link
Member

We need this for fluxcd/pkg project as well.

@stefanprodan
Copy link
Member

Thanks @aryan9600 for taking care of this 🥇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/ci CI related issues and pull requests
Projects
None yet
Development

No branches or pull requests

2 participants