Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

flux get sources - no output #2346

Closed
1 task done
kingdonb opened this issue Jan 26, 2022 · 1 comment · Fixed by #2347
Closed
1 task done

flux get sources - no output #2346

kingdonb opened this issue Jan 26, 2022 · 1 comment · Fixed by #2347

Comments

@kingdonb
Copy link
Member

Describe the bug

There is no output when the user types flux get sources by itself. This is jarring because users who didn't realize sources has only subcommands have to guess or find the help in order to discover that flux get sources git is what they meant.

My intuition is, this should do the same thing as flux get sources all because it's pretty clear what the user wants IMHO

We discussed it in slack though, and the consensus seems to be that it should print the help instead. If we overload the default to flux get sources all it will make it more difficult for users to discover the subcommands.

Steps to reproduce

UX issue described above

Expected behavior

It should not have zero output, it should perhaps exit 1 and print the help.

Alternatively, it could have the same effect as flux get sources all or flux get sources git.

Screenshots and recordings

No response

OS / Distro

Any

Flux version

v0.25.3

Flux check

N/A

Git provider

No response

Container Registry provider

No response

Additional context

No response

Code of Conduct

  • I agree to follow this project's Code of Conduct
@kingdonb
Copy link
Member Author

It seems that flux get already outputs the help, so it definitely makes sense to be consistent that flux get sources output the help, it should behave the same way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant