Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate use of libgit2 for git operations #323

Closed
pjbgf opened this issue Mar 2, 2022 · 0 comments · Fixed by #324
Closed

Consolidate use of libgit2 for git operations #323

pjbgf opened this issue Mar 2, 2022 · 0 comments · Fixed by #324
Assignees

Comments

@pjbgf
Copy link
Member

pjbgf commented Mar 2, 2022

The image automation controller leverages both libgit2/git2go and go-git for its interactions with git repositories.
Having two git libraries in use means code duplication and complexity that does not add any value to the project.

At present, the main use of go-git is for committing changed manifests:
https://github.com/fluxcd/image-automation-controller/blob/main/controllers/imageupdateautomation_controller.go#L571-L619

Besides that, the use of both libraries is intertwined in most tests.

We should consolidate all operations to a single git library, making it easier to maintain and improve our git interactions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

1 participant