-
Notifications
You must be signed in to change notification settings - Fork 181
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Garbage collection step is skipped if there are no manifests in the repo #187
Comments
We can't apply with kubectl an empty repository, and because apply happens before GC, it will never get to pruning since apply fails. |
Got it, thank you for the info! I don't have enough context in the order of reconciliation but could this work by skipping the application step, if validation returns an error, and continuing to prune? |
If the validation fails and we force GC, the it will delete everything due to using the old checksum. Imagine that a typo in a yaml will wipe your cluster clean... I find this unacceptable. |
Could we advise users to include some innocuous resource in each directory, which they never delete? |
A dummy configmap should do |
Hi, just stumbled across this issue and found this GH issue here. @stefanprodan can you maybe give an example with the dummy configmap? Will this create a real resource? Maybe this limitation should be added to docs with a workaround if its not going to be fixed. Best regards |
Noticed in version
ghcr.io/fluxcd/kustomize-controller:v0.2.2
Steps to reproduce
Kustomization
object withprune: true
.The deployment is scheduled.
In another test with two deployment manifests and then deleting one, the pod was removed fine
The text was updated successfully, but these errors were encountered: