Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add toleration support for Deployment resources #93

Closed
trillejs opened this issue Feb 10, 2021 · 4 comments · Fixed by #96
Closed

Add toleration support for Deployment resources #93

trillejs opened this issue Feb 10, 2021 · 4 comments · Fixed by #96

Comments

@trillejs
Copy link

Hi,

I am trying to deploy flux and I saw that it is possible to add custom annotations/labels/etc... with a kustomize patch after flux is deployed: https://toolkit.fluxcd.io/guides/installation/#customize-flux-manifests

However the source controller is not deploying because there is no way for me to add tolerations to the node taints I want to deploy it to.

Is there a way of doing this that I am missing?

@stefanprodan
Copy link
Member

Tolerations are a good candidate for manifestgen, this issue should be in flux2 repo.

@trillejs
Copy link
Author

I added a discussion regarding this on the flux2 repository:
fluxcd/flux2#895

@stefanprodan
Copy link
Member

Thanks 👍

@trillejs
Copy link
Author

In case someone ever needs to add tolerations, there is a horrible workaround where you insert the tolerations before the container string in the deployment definition:

install = [for v in data.kubectl_file_documents.install.documents : {
    data : yamldecode(v)
    content : replace(v, "containers:", "${local.toleration_string}\n      containers:")
    }
  ]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants