-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Pairdrop] text send dialog prefill doesn't work #274
Comments
Sorry for the delay, somehow I’ve overseen this. It took me a while to tidy up the code for PairDrop to follow the HTML style guide: https://google.github.io/styleguide/htmlcssguide.html#id_Attributes To make it easier to develop I needed to tidy up a lot of code and I don‘t want to rollback just for compatibility. Alternatively, you could differentiate PairDrop and Snapdrop whenever the instance is changed and look at the html meta tag: |
Not quite true. It does differentiate between text and files and shows the number of files: I like the idea of using a toast that is persistent though! "abort" seemed not right to me as you can share the content with multiple receivers once you are in pasteMode (as it is with AirDrop). Therefore I decided for "Done". Maybe similar to your solution I could add a title "Share Text" / "Share Files" and move the "Done" button to the side. Do you have another suggestion? As with AirDrop, I wanted the share to be executed by clicking only once. Having to approve the (prefilled) text box first, seems counter intuitive to me when I share text via the share-menu. I could imagine a compromise though: Paste Mode stays as is is but when text is shared it says What do you think? |
Indeed. However I had totally overlooked this text, doesn't seem prominent enough to me.
In english it is translated with "cancel" currently, another idea would be to use "finish". However "done" is fine as well, just lacking context currently.
Sounds good. Or maybe order them vertically (although this would take some more screen space)
I think it should be fine even without the edit functionality. I primarily have implemented that way because I had no idea how to do it better. |
Tbh I did not like it that much either as it didn’t show prominently enough what was being shared and the „Done“ button blocked the button header which could be useful while sharing. In the new version |
The new UI indeed looks pretty cool and is way more prominent. Like it, thanks for the great work! What are the endpoints for it / how would I trigger these components? |
Checklist
App version
master
Android version
10
Describe the bug
Text send prefill doesn't work, cause pairdrop uses a modified send text dialog
Steps to reproduce the bug
Stacktrace
No response
Screenshots and additional context
@schlagmichdoch maybe it's possible to rename the pairdrop.net html elements so that the current implementation works for both, snapdrop and pairdrop at the same time.
The text was updated successfully, but these errors were encountered: