-
Notifications
You must be signed in to change notification settings - Fork 134
Newer version of Tokio #129
Comments
Thank you @andrewrynhard for your suggestion. When I build examples of redbpf, tokio v0.2.22(https://github.com/tokio-rs/tokio/releases/tag/tokio-0.2.22) is selected by cargo dependency resolution. It is 433 commits behind the current master. Yes there is a huge gap between the old and new. And tokio started releasing stable versions since Dec 24, 2020. I lean to updating tokio, but I am not sure that updating causes side effect to existing users of redbpf. So I am going to look into it. |
I found some helpful articles about dependency resolution that Cargo performs. https://doc.rust-lang.org/cargo/reference/resolver.html These documents helped me understand what would happen if Tokio version is Before writing some code, what I should inspect are these:
I am going to write some PR for upgrading Tokio in this week. |
I think the upgrade should be fairly straightforward, and now with Actix following 1.x, I think we're all clear to make the move. I am not aware of exposing any Tokio-related structs through RedBPF, so I think just need to track down the API changes. |
Any thoughts on updating the version of Tokio to 1.3? Importing 1.3 and 0.2 into my crate is not the end of the world, but having one Tokio library to work with would be nice.
The text was updated successfully, but these errors were encountered: