Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

useSwipeable improvements #134

Closed
hartzis opened this issue Apr 5, 2019 · 0 comments · Fixed by #149
Closed

useSwipeable improvements #134

hartzis opened this issue Apr 5, 2019 · 0 comments · Fixed by #149
Assignees
@hartzis
Labels
enhancement

Comments

@hartzis
Copy link
Collaborator

hartzis commented Apr 5, 2019

useSwipeable re-creates internal functions too much? Look into possibilities of useEffect?

https://reactjs.org/docs/hooks-faq.html#what-can-i-do-if-my-effect-dependencies-change-too-often
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hartzis hartzis

Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Memoize hook output FaberVitale/react-swipeable
1 participant
@hartzis