Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fails to compile under newest nightly #69

Closed
vorner opened this issue May 21, 2019 · 1 comment
Closed

Fails to compile under newest nightly #69

vorner opened this issue May 21, 2019 · 1 comment

Comments

@vorner
Copy link
Contributor

vorner commented May 21, 2019

Hello

When trying to compile with today's nightly ($ rustc --version rustc 1.36.0-nightly (d35181ad8 2019-05-20)), the compilation fails with:

error[E0283]: type annotations required: cannot resolve `std::string::String: std::convert::AsRef<_>`
   --> src/output/prometheus.rs:150:41
    |
150 |         match minreq::get(self.push_url.as_ref())
    |     

AFAIK this „needs to be more specific“ errors are actually allowed breakage/acceptable exception to the stability promise ☹. So I'm not sure if it's worth reporting to rustc (I'll try it anyway, but it might be worth to add some annotations in dipstick too, just in case).

@vorner
Copy link
Contributor Author

vorner commented May 21, 2019

Ah, seems to be this rust-lang/rust#60958

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants