Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Opportunity for code cleanup: Remove deprecated methods registerChild #25

Open
mhdirkse opened this issue Jul 5, 2021 · 2 comments
Open

Comments

@mhdirkse
Copy link
Contributor

mhdirkse commented Jul 5, 2021

Describe the issue
The Frank!Doc is quite complicated. One of the reasons has to do with method registerChild. This method has multiple overloads, causing multiple ElementRole objects sharing the same element role. This situation requires complicated logic in the Frank!Doc. Method registerChild is deprecated however. If we remove the registerChild methods, we may be able to remove much logic from the Frank!Doc. Doing so will make future development more easy.

Reporter
Martijn Dirkse

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Screenshots
If applicable, add screenshots to help explain your problem.

Configuration

Please provide the configuration of the Pipe or Receiver with the problem.

Input

Please provide an example of the input message. 
Alternatively, provide a Ladybug report.

Environment

Please go to the console of your Frank, click on 'Information' and copy-paste the results here. 

Additional Environment

  • DBMS: [e.g. Oracle, MSSQL, MariaDB, MySql, PostgreSQL]
  • Browser: [e.g. Chrome, Safari, Edge, Firefox]

Additional Context
Add any other context about the problem here. (f.e. ladybug report / test adapter with larva test)

@jacodg
Copy link

jacodg commented Jul 12, 2021

We will do this later. Focus is now on releasing the xsd

@nielsm5 nielsm5 transferred this issue from frankframework/frankframework Nov 4, 2021
@mhdirkse
Copy link
Contributor Author

I checked whether we still have elements "Child" in the compatibility XSD. They are still there, so this issue cannot be picked up yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants