Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Self closing input element in html #5

Open
MatthijsSmets opened this issue May 28, 2024 · 4 comments
Open

Self closing input element in html #5

MatthijsSmets opened this issue May 28, 2024 · 4 comments

Comments

@MatthijsSmets
Copy link
Contributor

<input (change)="uploadReports($event)" type="file">
OF
<input (change)="uploadReports($event)" type="file"/>
@philipsens philipsens changed the title self closing input element in html Self closing input element in html May 28, 2024
@Matthbo
Copy link
Sponsor Member

Matthbo commented May 28, 2024

According to this article we should prevent using self-closing tags
https://jakearchibald.com/2023/against-self-closing-tags-in-html/

@philipsens
Copy link
Member

We can maybe achieve this with a linter, too.

@philipsens
Copy link
Member

philipsens commented Jun 11, 2024 •
edited by MatthijsSmets
Loading

Met Angular tags wel/niet?

  • Linter installeren en kijken hoe die er mee omgaat, dat zal meewegen in de beslissing.

@MatthijsSmets
Copy link
Contributor Author

MatthijsSmets commented Jul 3, 2024 •
edited
Loading

Deze linter rule gaat het worden @angular-eslint/template/prefer-self-closing-tags

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@Matthbo @philipsens @MatthijsSmets