Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unload package / Note of deleting #39

Closed
simonberger opened this issue Dec 22, 2015 · 1 comment
Closed

Unload package / Note of deleting #39

simonberger opened this issue Dec 22, 2015 · 1 comment

Comments

@simonberger
Copy link

I do not like the delete functionality of scrap. The name may hint it but isn't clear.
I had to clone a package again in the beginning because it deleted all files while I just wanted to unload the package.

Maybe it's a personal thing but in my opinion there shouldn't be a deletion of the files, but just an unload of the package (just reversing what it does on load).
If you guys think its correct I still would suggest an additional comment named unload which does that.

@franzliedke
Copy link
Owner

Okay, I just fixed this by adding a fat warning message before asking for confirmation. That should be good enough, right?

This will be included in the next stable release (v1.0) - we're just waiting for a pull request to Composer being merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants