Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some tests #71

Open
rask opened this issue Dec 1, 2016 · 8 comments
Open

Add some tests #71

rask opened this issue Dec 1, 2016 · 8 comments

Comments

@rask
Copy link
Contributor

rask commented Dec 1, 2016

There is only a single test available it seems. Would it be OK to contribute some tests? Also, could PHPUnit be used or is PhpSpec a 100% requirement? I'm more fluent with PHPUnit, but I presume PhpSpec is not that difficult to learn.

@rask
Copy link
Contributor Author

rask commented Dec 1, 2016

Noticed the PHP League related issue and saw a mention of required minimum test code coverage. This would help with that too if League is still a goal of sorts.

@franzliedke
Copy link
Owner

I'd love it if you would add some test, thanks for the suggestion!

If you want to, you can switch to PhpUnit, no strong opinions there.

@rask
Copy link
Contributor Author

rask commented Dec 5, 2016

Alrighty. Will send PRs when I get around to making some. Thanks for the information.

I read that PhpSpec shines in BDD/TDD (hence lack of coverage support "out-of-the-box": presumably BDD code is covered 100% as each test is created before any lines of any business logic), but as we are mostly retrofitting tests we can implement code coverage better with PHPUnit.

@rask
Copy link
Contributor Author

rask commented Dec 23, 2016

Is there a current PHP version requirement in place? Need to know for tests so I won't write tests that explode if they're run on a version that is supposed to be supported. I presume at least 5.6 should be supported?

@franzliedke
Copy link
Owner

@rask Thanks for keeping it up.

According to the Travis setup, we currently support everything starting at PHP 5.4.

@rask
Copy link
Contributor Author

rask commented Dec 29, 2016

Oh I missed the Travis config. Thanks for the pointer. Will try to keep it 5.4 friendly. 👍

@rask
Copy link
Contributor Author

rask commented Jan 27, 2017

I've been busy with life but made some progress with some tests for studio. I'll try to get a PR up this weekend or early next week.

@franzliedke
Copy link
Owner

Cool!

I will appreciate it whenever you submit something. No worries. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants