Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dialog가 ESC로 꺼지지 않는 오류 #75

Closed
hae-on opened this issue Oct 18, 2023 · 0 comments · Fixed by #86
Closed

dialog가 ESC로 꺼지지 않는 오류 #75

hae-on opened this issue Oct 18, 2023 · 0 comments · Fixed by #86
Assignees
@hae-on
Labels
🐛 Bug

Comments

@hae-on
Copy link
Collaborator

hae-on commented Oct 18, 2023

버그가 발생한 곳

dialog 컴포넌트

버그 상황 재연

스크린샷을 첨부하면 더 좋아요!

dialog가 현재 div이기 때문에 ESC로 꺼지지 않습니다.
예전에 만들었던 useEnterKey 어쩌고 hook이 있었는데
그걸 다시 부활시키도록 하겠습니다..

현재 동작

dialog가 ESC로 꺼지지 않습니다.

기대 동작

dialog가 ESC로 꺼집니다.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hae-on hae-on

Labels
🐛 Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

웹 접근성 개선과 토스트 문서 추가 fun-eat/design-system
1 participant
@hae-on