Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ESM #34

Closed
furudean opened this issue Jul 27, 2024 · 1 comment
Closed

Use ESM #34

furudean opened this issue Jul 27, 2024 · 1 comment

Comments

@furudean
Copy link
Owner

furudean commented Jul 27, 2024 •
edited
Loading

Packages used in this repository have ditched node's require() support, which prevents us from upgrading some of them.

require() is what gets used under the hood after the typescript code is transpiled into javascript. I remember reading that VSCode extensions don't actually support ESM natively yet but I can't find this piece of literature now. If I find it I'll drop it here
@furudean
Copy link
Owner Author

Depends on microsoft/vscode#130367

Looks like it's technically possible, but you have to bundle as commonjs first, which I don't really want to do. So complete upstream support is a must

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@furudean