-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert to ESM module (BREAKING). Target: end of beta cycle. #126
Comments
Actually we can do the "Dual" approach from the Rationale link above, then it's not a breaking change. We'll make the library ESM but also have a build step that transpiles a CommonJS fallback. |
😆 I was about to open an issue for this! You beat me to it! Yes, I agree. ESModules will a lot better for the rest of the ecosystem. Suggested Timeline
DualI would say that we should not stick to the dual approach. We can start with it, but we should remove the CJS fallback at the end of April. |
Thanks, @PythonCreator27, glad to hear others are on board for this 🙏 Yes, I don't want to support dual moving forward. But I think we can give people a bit more time to get ready if it doesn't cost us anything. Maybe 6 months with a big fat warning with anyone loading the CJS fallback. From what I understood, as long as we provide the fallback, it won't be a breaking change and should be transparent to the user. It will only be a breaking change / new major version when we drop the fallback. |
🎉 This issue has been resolved in version 1.11.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Rationale
Sindre Sorhus: Get Ready For ESM
Implementation
Sindre Sorhus: Pure ESM package
Sugested timeline
rc
tag.The text was updated successfully, but these errors were encountered: