Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test the widget in Safari #12

Closed
noahlevenson opened this issue Nov 9, 2022 · 5 comments
Closed

Test the widget in Safari #12

noahlevenson opened this issue Nov 9, 2022 · 5 comments

Comments

@noahlevenson
Copy link
Contributor

We need to make this part of our testing flow. I ought to be doing it as part of my informal build poking, but I don't own a mac.

@soltzen soltzen self-assigned this Dec 2, 2022
@soltzen
Copy link

soltzen commented Dec 2, 2022

This is kinda of an ongoing task as part of regular testing, but I'll test the main workflow once and report back any weirdnesses

@noahlevenson
Copy link
Contributor Author

A report from @woodybury obtained in pursuit of #45:

Desktop Safari is broken. It exhibits the same bug as mobile browsers on iOS. Since mobile browsers on iOS and desktop Safari have WebKit in common, we surmise that WebKit is the problem.

From desktop Safari:

WebSocket connection to 'ws://localhost:8080/ws' failed: The operation couldn't be completed. (kNWErrorDomainPOSIX error 100 - Protocol error)
writeSync — main.js:2:252752

@noahlevenson
Copy link
Contributor Author

In light of the workaround in adb7c82 which fixes #45, I suspect that desktop Safari is all good now. Someone should confirm it, though.

@woodybury
Copy link
Contributor

@noahlevenson i hereby confirm

@noahlevenson
Copy link
Contributor Author

@woodybury ratified by the committee

@soltzen I'm gonna close this, since we wound up learning more about Safari today than I think anyone had ever hoped to. But we do still need to establish a regular testing flow that involves cross-browser poking. I'm not sure how to best initiate that, but it's probably a topic for a separate ticket.

@soltzen soltzen removed their assignment Dec 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants