From 81e0fd1ad20a9dcf442e0cc39b6ccf091cc4a2e6 Mon Sep 17 00:00:00 2001
From: Francesco Novy <francesco.novy@sentry.io>
Date: Wed, 29 May 2024 14:12:20 +0200
Subject: [PATCH] build: Bump node to 18.20.3 (#12271)

I noticed that locally the node-integration-tests that check versions
fail, because in the SDK we use 18.18.0, we only check for "If
node.major >= 18", and then get an incorrect test because actually in
code we check the minor too.

Instead of adjust this, IMHO it's better to update this. This also never
failed on CI because there we do use latest 18 for the matrix tests...
---
 .size-limit.js                                                | 4 ++--
 dev-packages/e2e-tests/package.json                           | 3 +--
 .../test-applications/node-express-cjs-preload/package.json   | 3 +--
 .../test-applications/node-express-esm-loader/package.json    | 3 +--
 .../test-applications/node-express-esm-preload/package.json   | 3 +--
 .../node-express-esm-without-loader/package.json              | 3 +--
 package.json                                                  | 2 +-
 7 files changed, 8 insertions(+), 13 deletions(-)

diff --git a/.size-limit.js b/.size-limit.js
index 0d8af3d8d7d5..8a55b86e9b5e 100644
--- a/.size-limit.js
+++ b/.size-limit.js
@@ -149,7 +149,7 @@ module.exports = [
     name: 'CDN Bundle (incl. Tracing, Replay)',
     path: createCDNPath('bundle.tracing.replay.min.js'),
     gzip: true,
-    limit: '70 KB',
+    limit: '72 KB',
   },
   {
     name: 'CDN Bundle (incl. Tracing, Replay, Feedback)',
@@ -170,7 +170,7 @@ module.exports = [
     path: createCDNPath('bundle.tracing.min.js'),
     gzip: false,
     brotli: false,
-    limit: '105 KB',
+    limit: '110 KB',
   },
   {
     name: 'CDN Bundle (incl. Tracing, Replay) - uncompressed',
diff --git a/dev-packages/e2e-tests/package.json b/dev-packages/e2e-tests/package.json
index bcab25973641..f34e41a7c2d5 100644
--- a/dev-packages/e2e-tests/package.json
+++ b/dev-packages/e2e-tests/package.json
@@ -27,8 +27,7 @@
     "yaml": "2.2.2"
   },
   "volta": {
-    "node": "18.20.2",
-    "yarn": "1.22.22",
+    "extends": "../../package.json",
     "pnpm": "8.15.8"
   }
 }
diff --git a/dev-packages/e2e-tests/test-applications/node-express-cjs-preload/package.json b/dev-packages/e2e-tests/test-applications/node-express-cjs-preload/package.json
index 8d98a54b8d7e..660d5147bb27 100644
--- a/dev-packages/e2e-tests/test-applications/node-express-cjs-preload/package.json
+++ b/dev-packages/e2e-tests/test-applications/node-express-cjs-preload/package.json
@@ -18,7 +18,6 @@
     "@playwright/test": "^1.27.1"
   },
   "volta": {
-    "extends": "../../package.json",
-    "node": "18.19.1"
+    "extends": "../../package.json"
   }
 }
diff --git a/dev-packages/e2e-tests/test-applications/node-express-esm-loader/package.json b/dev-packages/e2e-tests/test-applications/node-express-esm-loader/package.json
index 2d3bbb738945..e05d8711ff33 100644
--- a/dev-packages/e2e-tests/test-applications/node-express-esm-loader/package.json
+++ b/dev-packages/e2e-tests/test-applications/node-express-esm-loader/package.json
@@ -18,7 +18,6 @@
     "@playwright/test": "^1.27.1"
   },
   "volta": {
-    "extends": "../../package.json",
-    "node": "18.19.1"
+    "extends": "../../package.json"
   }
 }
diff --git a/dev-packages/e2e-tests/test-applications/node-express-esm-preload/package.json b/dev-packages/e2e-tests/test-applications/node-express-esm-preload/package.json
index 20bda187d3a2..3f2310549513 100644
--- a/dev-packages/e2e-tests/test-applications/node-express-esm-preload/package.json
+++ b/dev-packages/e2e-tests/test-applications/node-express-esm-preload/package.json
@@ -18,7 +18,6 @@
     "@playwright/test": "^1.27.1"
   },
   "volta": {
-    "extends": "../../package.json",
-    "node": "18.19.1"
+    "extends": "../../package.json"
   }
 }
diff --git a/dev-packages/e2e-tests/test-applications/node-express-esm-without-loader/package.json b/dev-packages/e2e-tests/test-applications/node-express-esm-without-loader/package.json
index b339fa65d2a2..8b8a34966174 100644
--- a/dev-packages/e2e-tests/test-applications/node-express-esm-without-loader/package.json
+++ b/dev-packages/e2e-tests/test-applications/node-express-esm-without-loader/package.json
@@ -18,7 +18,6 @@
     "@playwright/test": "^1.27.1"
   },
   "volta": {
-    "extends": "../../package.json",
-    "node": "18.19.1"
+    "extends": "../../package.json"
   }
 }
diff --git a/package.json b/package.json
index 70b7663667f4..907457557e86 100644
--- a/package.json
+++ b/package.json
@@ -41,7 +41,7 @@
     "yalc:publish": "lerna run yalc:publish"
   },
   "volta": {
-    "node": "18.18.0",
+    "node": "18.20.3",
     "yarn": "1.22.19"
   },
   "workspaces": [