Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Send Standalone CLS spans #13015

Open
10 of 12 tasks
Lms24 opened this issue Jul 23, 2024 · 0 comments
Open
10 of 12 tasks

Send Standalone CLS spans #13015

Lms24 opened this issue Jul 23, 2024 · 0 comments
Assignees
Labels

Comments

@Lms24
Copy link
Member

Lms24 commented Jul 23, 2024

Description

(Extracted from #12714 to split up CLS and LCP spans)

A basic CLS span implmentation needs to:

  • ensure we either only send CLS as pageload span measurements (old way) OR as standalone spans
  • Attach the user-agent span.data
  • Attach an exclusive_time to the stand alone span
  • Guard sending the span with an _experimental browserTracing option
  • Ensure we also stop recording CLS once users navigate. The web vitals library does not reset the CLS score after navigations.
  • Re-think 0-CLS fix
  • Ensure we don't break current Replay CLS collection
  • Ensure we don't break future Replay CLS collection
  • Check span payload with Ingest and Performance team
  • ensure standalone span also carries the attribution HTML node as attributes? @edwardgou-sentry (when you're back) does this make sense? I just wonder how we'd continue showing the nodes if the CLS span is not shown in the Sentry UI. Does it even make sense to continue sending the nodes then? We can also set the span name to the html tree as string like we do for INP.
  • Wait for Ingest changes
  • Test on Sentry
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant