Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DSC] Unify baggage and envelope header structure #5301

Closed
Lms24 opened this issue Jun 23, 2022 · 0 comments · Fixed by #5302
Closed

[DSC] Unify baggage and envelope header structure #5301

Lms24 opened this issue Jun 23, 2022 · 0 comments · Fixed by #5302
Assignees
@Lms24
Milestone
Dynamic Sampling

Comments

@Lms24
Copy link
Member

Lms24 commented Jun 23, 2022

As now set in the spec, we unify the structure of how DSC is sent in both baggage Http and trace envelope header.

This means that

  • all previous keys in baggage shall be changed so that they only differ by the sentry- prefix but are otherwise identical with the envelope header key names
  • the user object in the envelope header shall be flattened to two separate fields, user_id and user_segment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Lms24 Lms24

Labels
None yet
Projects
None yet
Milestone
Dynamic Sampling
Development

Successfully merging a pull request may close this issue.

ref(tracing): Unify DSC key names in envelope and baggage headers getsentry/sentry-javascript
1 participant
@Lms24