From 4529cf558c22e40d15249499175a5267b02d0b8d Mon Sep 17 00:00:00 2001
From: Jan Michael Auer <mail@jauer.org>
Date: Fri, 19 Jun 2020 20:25:07 +0200
Subject: [PATCH] ref: Back out crashpad integration tests

---
 tests/test_integration_crashpad.py | 67 ++++--------------------------
 1 file changed, 7 insertions(+), 60 deletions(-)

diff --git a/tests/test_integration_crashpad.py b/tests/test_integration_crashpad.py
index 96441be4e..23359b307 100644
--- a/tests/test_integration_crashpad.py
+++ b/tests/test_integration_crashpad.py
@@ -1,9 +1,6 @@
 import pytest
-import os
-import time
-from . import make_dsn, run, Envelope
-from .conditions import has_crashpad, has_http
-from .assertions import assert_session
+from .conditions import has_crashpad
+from . import cmake
 
 # TODO:
 # * with crashpad backend:
@@ -12,60 +9,10 @@
 #   - expect report via http
 
 
-@pytest.mark.skipif(
-    not has_http or not has_crashpad, reason="test needs crashpad backend"
-)
-def test_crashpad_capture(cmake, httpserver):
-    tmp_path = cmake(["sentry_example"], {"SENTRY_BACKEND": "crashpad"})
-
-    httpserver.expect_request("/api/123456/envelope/").respond_with_data("OK")
-
-    run(
-        tmp_path,
-        "sentry_example",
-        ["log", "start-session", "capture-event"],
-        check=True,
-        env=dict(os.environ, SENTRY_DSN=make_dsn(httpserver)),
-    )
-
-    assert len(httpserver.log) == 2
-
-
-@pytest.mark.skipif(
-    not has_http or not has_crashpad, reason="test needs crashpad backend"
-)
-def test_crashpad_crash(cmake, httpserver):
-    tmp_path = cmake(["sentry_example"], {"SENTRY_BACKEND": "crashpad"})
-
-    httpserver.expect_request("/api/123456/minidump/").respond_with_data("OK")
-    httpserver.expect_request("/api/123456/envelope/").respond_with_data("OK")
-
-    child = run(
+@pytest.mark.skipif(not has_crashpad, reason="test needs crashpad backend")
+def test_crashpad_build(tmp_path):
+    cmake(
         tmp_path,
-        "sentry_example",
-        ["log", "start-session", "attachment", "overflow-breadcrumbs", "crash"],
+        ["sentry_example"],
+        {"SENTRY_BACKEND": "crashpad", "SENTRY_TRANSPORT": "none"},
     )
-    assert child.returncode  # well, its a crash after all
-
-    run(
-        tmp_path,
-        "sentry_example",
-        ["log", "no-setup"],
-        check=True,
-        env=dict(os.environ, SENTRY_DSN=make_dsn(httpserver)),
-    )
-
-    time.sleep(2)  # lets wait a bit for crashpad sending in the background
-
-    assert len(httpserver.log) == 2
-    outputs = (httpserver.log[0][0].get_data(), httpserver.log[1][0].get_data())
-    session, multipart = (
-        outputs if b'"type":"session"' in outputs[0] else (outputs[1], outputs[0])
-    )
-
-    envelope = Envelope.deserialize(session)
-    assert_session(envelope, {"status": "abnormal", "errors": 0})
-
-    # TODO: crashpad actually sends a compressed multipart request,
-    # which we don’t parse / assert right now.
-    # Ideally, we would pull in a real relay to do all the http tests against.