Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to hermesProfilingIntegration to only profile Hermes JS #4085

Closed
krystofwoldrich opened this issue Sep 12, 2024 · 0 comments · Fixed by #4094
Closed

Add option to hermesProfilingIntegration to only profile Hermes JS #4085

krystofwoldrich opened this issue Sep 12, 2024 · 0 comments · Fixed by #4094

Comments

@krystofwoldrich
Copy link
Member

Description

When profilesSampleRate set in Sentry.init of the React Native SDK both Hermes JS and Android JVM or iOS native profiler are recording.

This issue is proposing an option to only enable Hermes JS profiling if user doesn't want to profile the native threads.

Sentry.init({
  profilesSampleRate: 1.0,
  integration: [
    Sentry.hermesProfilingIntegration({
      platformProfilers: false
    }),
  ],
})
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

2 participants