-
Notifications
You must be signed in to change notification settings - Fork 186
passing empty wayland raw window handle segfaults in safe code #78
Comments
Right, we should be null checking here if anyone would like to take a look at improving this. |
I don't know if we can even truly address this. Users can always provide garbage pointers in |
As per the
It should be enough to just check for |
|
We also came to the same conclusion (this interface can be made safe as long as we check for 0/null on all the fields we need, in a platform-dependent way). I think it would be best to do this check directly in gfx-rs since we know exactly which handles we need at any given time. So I might take a stab at this (it would also be much better if this returns a Result rather than panicking; we ran into issues with gfx-rs panicking on "obvious" errors that we couldn't easily catch at runtime, and I think almost anyone would trade having to handle a Result for safety). |
Closing in favor of #674 |
Using wgpu 0.3.0,
This will cause a segfault in safe code.
The text was updated successfully, but these errors were encountered: