Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Freeing resources after device loss should use Device::trackers to find resources, not Device::life_tracker #4907

Closed
jimblandy opened this issue Dec 21, 2023 · 2 comments
Labels
area: correctness We're behaving incorrectly type: bug Something isn't working

Comments

@jimblandy
Copy link
Member

At present, device loss uses LifetimeTracker::release_gpu_resources to find buffers to free. However, Device::life_tracker does not hold a complete record of all resources created with the device. For buffers, for example, it only mentions buffers that are waiting to be mapped or ready to be mapped. Device::trackers, however, holds a Tracker whose buffers field holds all buffers owned by the Device, which is exactly what device loss needs.

@jimblandy jimblandy added type: bug Something isn't working area: correctness We're behaving incorrectly labels Dec 21, 2023
@jimblandy jimblandy added this to the WebGPU Specification V1 milestone Dec 21, 2023
@jimblandy
Copy link
Member Author

This would be a follow-up to #4851. CC @bradwerth

@teoxoy
Copy link
Member

teoxoy commented Jul 4, 2024

#5075 resolved this.

@teoxoy teoxoy closed this as completed Jul 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: correctness We're behaving incorrectly type: bug Something isn't working
Projects
Status: Done
Development

No branches or pull requests

2 participants