From 3e05bd748cfd07e251db8ec4a77153e9dc5fe499 Mon Sep 17 00:00:00 2001
From: Gibson Fahnestock <gibfahn@gmail.com>
Date: Mon, 3 Jun 2019 17:15:55 +0100
Subject: [PATCH] macOS: add comment for permissions error with defaults write

Also add shellcheck to Brewfile.

Refs: https://github.com/mathiasbynens/dotfiles/issues/849
---
 README.md                      | 1 +
 helpers/setup.sh               | 3 ++-
 setup/config/Brewfile-hardcore | 1 +
 3 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/README.md b/README.md
index 0b594b4e..775580b7 100644
--- a/README.md
+++ b/README.md
@@ -146,6 +146,7 @@ Some things you have to do manually:
     - `Show full website address` -> Tick
     - `Press Tab to highlight each item on a webpage`
     - `Show Develop menu in menu bar`
+- Give Kitty full disk access: `System Preferences` -> `Privacy` -> `Full Disk Access`.
 
 ## Adding a new file to your dotfiles
 
diff --git a/helpers/setup.sh b/helpers/setup.sh
index 67ef2caa..b6dd81fe 100644
--- a/helpers/setup.sh
+++ b/helpers/setup.sh
@@ -226,7 +226,8 @@ updateMacOSKeyboardShortcut() {
   updateMacOSDefaultDict "$1" NSUserKeyEquivalents "$2" "$3"
   if ! defaults read com.apple.universalaccess com.apple.custommenu.apps | grep -qF "$1"; then
     update "macOS default shortcut $1 is not in com.apple.universalaccess com.apple.custommenu.apps, adding it."
-    sudo defaults write com.apple.universalaccess com.apple.custommenu.apps -array-add "$1"
+    defaults write com.apple.universalaccess com.apple.custommenu.apps -array-add "$1" \
+      || echo "Add the current Terminal app to System Preferences -> Privacy -> Full Disk Access."
   fi
 }
 
diff --git a/setup/config/Brewfile-hardcore b/setup/config/Brewfile-hardcore
index ff2eb717..84c3450d 100644
--- a/setup/config/Brewfile-hardcore
+++ b/setup/config/Brewfile-hardcore
@@ -12,6 +12,7 @@ brew "go"                                # Go progamming language.
 brew "ninja"                             # Google meta build system (used in V8).
 brew "postgresql"                        # Solid database.
 brew "protobuf"                          # Serialization format.
+brew "shellcheck"                        # Linter for bash.
 brew "redis"                             # In-memory key-object store.
 brew "srkomodo/tap/shadowfox-updater"    # ShadowFox Firefox Universal Dark Theme Updater (`shadowfox` to install).
 brew "watchexec"                         # Like entr (evaluating which one is better).