Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

async stack recording #54

Open
friflo opened this issue May 28, 2019 · 3 comments
Open

async stack recording #54

friflo opened this issue May 28, 2019 · 3 comments

Comments

@friflo
Copy link

friflo commented May 28, 2019

hey gildor,
smart work :)
Do you plan to support "Async stack recording" to see the origin caller in case of an exception within retrofit?
Similar as you did in https://github.com/gildor/kotlin-coroutines-okhttp

@gildor
Copy link
Owner

gildor commented May 28, 2019

Hi! Not really, I will probably remove it from kotlin-coroutines-okhttp.
The reason is that current debug mode for kotlinx.coroutines is pretty good and gives a very nice result, also you can actually enable it on prod (see Kotlin/kotlinx.coroutines#1188)

Do you have any problems with debug mode for kotlinx.coroutines? Do you have an example of stack trace with debug mode?

@friflo
Copy link
Author

friflo commented May 29, 2019

What I want is the origin caller in the stack in case of an exception, when calling a REST API via retrofit.
I also found
https://github.com/Kotlin/kotlinx.coroutines/blob/master/docs/debugging.md
before, but I simply was not able to get stacktrace.recovery successful running in Android JUnit test or in an Android App.
So I was looking for an alternative.

@gildor
Copy link
Owner

gildor commented May 30, 2019

I would then try to reproduce your issue and report it to kotlinx.coroutines, do you have some sample?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants