Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Layout tab : custom command not saved #21

Open
LionelHoudelier opened this issue Jul 10, 2023 · 3 comments
Open

Layout tab : custom command not saved #21

LionelHoudelier opened this issue Jul 10, 2023 · 3 comments

Comments

@LionelHoudelier
Copy link
Contributor

LionelHoudelier commented Jul 10, 2023

In Layout tab:

  • add a new layout from existing window with different terminals
  • or edit one
  • add a custom command for a terminal
  • click save
  • then the command disappears
    any idea why?
@mattrose
Copy link
Member

I did look at this a while back, and it has to do with the layout save procedure. There is a github issue about it, but I'm mostly concentrating on trying to update to GTK4 right now.

@LionelHoudelier
Copy link
Contributor Author

LionelHoudelier commented Jul 10, 2023

yes. because we cannot change the saved layout, so the save action cancels the changed options (profile, custom command, working folder). sad. It is a wonderful app in development! Thank you so much.
I am looking at the code to see where to change the action.
HALF-SOLVED:
Do not press "save".

@apnea
Copy link

apnea commented Apr 22, 2024

The issue is actually that the button should not say Save but something like Refresh or Reset :

  • the behaviour of this dialog is that changes get saved when the user hits enter, by invoking self.config.save()
  • while the button click in question resets any changes

Therefore a Save button is not needed and misleading. The existing code and glade file uses the term layoutrefresh to refer to the button behaviour, so this looks like a simple oversight in the button property in preferences.glade.

I'll do a pull request with the change from gtk-save to gtk-refresh to bring the glade file in line with the code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants