Create new built in function adds parentheses

[TheColorRed]

When creating a function such as _ready, _process, etc., opening and closing parentheses is created after the colon:

[Calinou]

Related to #184.

Which other VS Code extensions do you have enabled? Maybe one of them could interfere with autocompletion. (I haven't tested this locally.)

[TheColorRed]

There shouldn't be any that interfere, these are the only ones I have enabled:

[TheColorRed]

After testing more out, they each seem to work differently.

func _get_configuration_warning() -> String:
func _draw() -> void:()
func _process(delta: float) -> void:(
func _unhandled_input(event: InputEvent) -> void:(

• Some are correct
• Some have parentheses
• Some don't have parentheses
• Some have an opening parentheses

[Calinou]

I think _get() doesn't have a return type because it can return anything. GDScript doesn't have an any return type yet (and doesn't allow to use Variant as a return type), so it has to be ommitted for now.

[TheColorRed]

Okay, I have removed that from the list of tested items.

[Razoric480]

func _get_configuration_warning() -> String:() adds parenthesis at the end for me, so it's also not correct. Though the other 3 are as stated.

[Razoric480]

I've finally investigated this eons later and can confirm that it's an issue with the LSP.

if ((item.kind == lsp::CompletionItemKind::Method || item.kind == lsp::CompletionItemKind::Function) && !item.label.ends_with("):")) {
		item.insertText = item.label + "(";
		if (symbol && symbol->children.empty()) {
			item.insertText += ")";
		}
	}

does not take into consideration instances where static typing is included with ->.

[Misignu]

No any possible fix? This bug is a bit annoying.

[Calinou]

@Misignu This is a bug that needs to be fixed in Godot's C++ code, not in the Visual Studio Code extension. Due to this, it will have to wait until someone opens a pull request to fix this on godotengine/godot and gets it merged.

[TheColorRed]

This seems to have been resolved. I am not seeing the issue anymore.