Writing bool values to PoolByteArray works in debug but not release exports

[HaSa1002]

Godot version:
3.3.1

OS/device including version:
Windows 10, 19042.928

Issue description:
You can't write to PoolVectorArrays in release exports.
Debug (Editor/Export):

======= BOOL =======
Start:		00000
Expected:	00100
Got:		00100

Release Export:

======= BOOL =======
Start:		00000
Expected:	00100
Got:		00000

with code:

print("======= BOOL =======")
print("Start:\t\t", pba_str(byte_data))
byte_data[2] = true
print("Expected:\t00100\nGot:\t\t", pba_str(byte_data))

Steps to reproduce:

1. Open MRP
2. Run in Editor
3. Export
4. Uncheck "Export with Debug"
5. Run exported build

Minimal reproduction project:
PoolVector.zip
The project includes test for all PoolVector types.

[Calinou]

In Godot 3.x, Pool*Arrays are passed by value instead of reference. Maybe that explains it? Either way, the behavior should not differ between debug and release.

In Godot 4.0, Packed*Arrays are passed by reference until they're passed to a low-level server, in which case they are passed by value.

[HaSa1002]

More context than in the snippet above:

extends Node
var byte_data := PoolByteArray([false, false, false, false, false])

func _ready():
	print("======= BOOL =======")
	print("Start:\t\t", pba_str(byte_data))
	byte_data[2] = true
	print("Expected:\t00100\nGot:\t\t", pba_str(byte_data))

I access the Vector by value there.

[akien-mga]

That's a weird bug, but it seems to be related to your use of boolean values. It works fine with ints:

var byte_data := PoolByteArray([0, 1, 2, 3, 4])

func _ready():
        print("before")
        for b in byte_data: print(b)
        byte_data[2] = 6
        print("after")
        for b in byte_data: print(b)

before
0
1
2
3
4
after
0
1
6
3
4

It works fine if you cast the bool to int explicitly (byte_data[2] = int(true)).

[HaSa1002]

Okay. Good to know. That seems to be an GDScript bug?
I can workaround my Input.is_action_pressed with int(...) then.

[Xrayez]

That seems to be an GDScript bug?

Yeah, looks like GDScript issue to me, there were many debug vs. release differences in GDScript implementation in the past.

[akien-mga]

Fixed by #57851.