Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Godot Web Editor not using/allowing gles3 #52455

Closed
SIsilicon opened this issue Sep 7, 2021 · 8 comments
Closed

Godot Web Editor not using/allowing gles3 #52455

SIsilicon opened this issue Sep 7, 2021 · 8 comments

Comments

@SIsilicon
Copy link

SIsilicon commented Sep 7, 2021

Godot version

3.3.3.stable

System information

Windows 10, Google Chrome Browser

Issue description

Even though the editor may say that is using GLES 3, all the objects and the editor itself still act as if it's running in GLES 2.
edit And yes, the browser supports WebGL 2.0.
edit Also, I checked and this quirk has been here since Godot 3.3.

Steps to reproduce

Just enter a project with GLES 3. If you try to edit the environment, you'll notice that features such as ssao and tone mapping are not available.

Minimal reproduction project

No response

@akien-mga
Copy link
Member

If you try to edit the environment, you'll notice that features such as ssao and tone mapping are not available.

Indeed, I can reproduce this. This indeed means that the rasterizer implementation reports true for VisualServer::get_singleton()->is_low_end(), i.e. it's GLES2. Any idea why @Faless?

@Faless
Copy link
Collaborator

Faless commented Sep 18, 2021

GLES3 (WebGL2) has always been disabled in the Web Editor.

@Faless
Copy link
Collaborator

Faless commented Sep 18, 2021

Originally, the project manager would not allow you to create GLES3 projects at all, not sure when it changed.

@SIsilicon
Copy link
Author

SIsilicon commented Sep 18, 2021

Here?

#ifdef TOOLS_ENABLED
bool gles3 = false;
#else
bool gles3 = true;
if (p_video_driver == VIDEO_DRIVER_GLES2) {
gles3 = false;
}
#endif

According to the blame, this was 12 months ago from this commit.

@Faless
Copy link
Collaborator

Faless commented Sep 18, 2021

@SIsilicon that's the commit that disables GLES3 for the web editor.
As I said, it has always been disabled, but that was also reflected in the project manager creation pop-up, which doesn't seem to be the case right now.

@akien-mga
Copy link
Member

IIRC it was disabled in the prototype phase due to issues, but I don't think we aimed for it to stay this way. Do you remember what the issues were? Was it just context switching being problematic?

@Faless
Copy link
Collaborator

Faless commented Sep 18, 2021

IIRC the reason was browsers never really free the GL context. Which means the canvas must be deleted and recreated every time the editor or game changes from GLES3 to GLES2. It needs some rework of the misc/html/editor.html page I think.

@akien-mga
Copy link
Member

Fixed by #53991.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants