Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IsDescendant/IsAncestor returns true for self #9925

Closed
bep opened this issue May 25, 2022 · 4 comments
Closed

IsDescendant/IsAncestor returns true for self #9925

bep opened this issue May 25, 2022 · 4 comments
Assignees

Comments

@bep
Copy link
Member

bep commented May 25, 2022

This relates to #9846.

I don't remember the history here, but I can see where I got confused, which is an indication that this needs to be fixed.

The thing is, currently, for a given section:

{{ $mysection.IsDescendant $mysection }} => true 
{{ $mysection.IsAncestor $mysection }} => true 
{{ site.Home.IsDescendant site.Home }} => true 
{{ site.Home.IsAncestor site.Home }} => true 

Which does not make much sense. Fixing the above fixes #9846 but introduces a test failure that looks synthetic. If someone thinks fixing this would have breaking effects, shout.

/cc @jmooring

@bep bep self-assigned this May 25, 2022
@bep bep removed the NeedsTriage label May 25, 2022
@bep
Copy link
Member Author

bep commented May 26, 2022

OK, this has been a theme before: #7206 ...

@bep
Copy link
Member Author

bep commented May 26, 2022

No, we need to fix this, see my comment in #9926 (comment)

@jmooring
Copy link
Member

Fixed with #9926

@github-actions
Copy link

This issue has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants