diff --git a/dashboard/builders_test.go b/dashboard/builders_test.go index 5314d4b07e..3ef5036aba 100644 --- a/dashboard/builders_test.go +++ b/dashboard/builders_test.go @@ -1084,7 +1084,7 @@ func TestHostConfigIsVM(t *testing.T) { }, } for _, tc := range testCases { - t.Run(fmt.Sprintf(tc.desc), func(t *testing.T) { + t.Run(tc.desc, func(t *testing.T) { if got := tc.config.IsVM(); got != tc.want { t.Errorf("HostConfig.IsVM() = %t; want %t", got, tc.want) } diff --git a/internal/buildgo/buildgo.go b/internal/buildgo/buildgo.go index 645b9b2e34..be98958f1a 100644 --- a/internal/buildgo/buildgo.go +++ b/internal/buildgo/buildgo.go @@ -224,7 +224,7 @@ func VersionTgz(rev string) io.Reader { } } - contents := fmt.Sprintf("devel " + rev) + contents := "devel " + rev check(tw.WriteHeader(&tar.Header{ Name: "VERSION", Mode: 0644, diff --git a/internal/cloud/aws_test.go b/internal/cloud/aws_test.go index 4861ddf124..d2d15890b8 100644 --- a/internal/cloud/aws_test.go +++ b/internal/cloud/aws_test.go @@ -325,17 +325,17 @@ func fakeClientWithInstances(t *testing.T, count int, opts ...option) (*AWSClien func randomVMConfig() *EC2VMConfiguration { return &EC2VMConfiguration{ - Description: fmt.Sprintf("description-" + randHex(4)), - ImageID: fmt.Sprintf("image-" + randHex(4)), - Name: fmt.Sprintf("name-" + randHex(4)), - SSHKeyID: fmt.Sprintf("ssh-key-id-" + randHex(4)), - SecurityGroups: []string{fmt.Sprintf("sg-" + randHex(4))}, + Description: "description-" + randHex(4), + ImageID: "image-" + randHex(4), + Name: "name-" + randHex(4), + SSHKeyID: "ssh-key-id-" + randHex(4), + SecurityGroups: []string{"sg-" + randHex(4)}, Tags: map[string]string{ - fmt.Sprintf("tag-key-" + randHex(4)): fmt.Sprintf("tag-value-" + randHex(4)), + "tag-key-" + randHex(4): "tag-value-" + randHex(4), }, - Type: fmt.Sprintf("type-" + randHex(4)), - UserData: fmt.Sprintf("user-data-" + randHex(4)), - Zone: fmt.Sprintf("zone-" + randHex(4)), + Type: "type-" + randHex(4), + UserData: "user-data-" + randHex(4), + Zone: "zone-" + randHex(4), } } diff --git a/internal/relui/workflows.go b/internal/relui/workflows.go index d58da756c4..d59e07f837 100644 --- a/internal/relui/workflows.go +++ b/internal/relui/workflows.go @@ -1552,7 +1552,7 @@ func (tasks *BuildReleaseTasks) uploadModules(ctx *wf.TaskContext, version strin want := map[string]bool{} // URLs we're waiting on becoming available. for _, mod := range modules { base := task.ToolchainModuleVersion(mod.Target, version) - if err := tasks.uploadFile(ctx, servingFS, mod.ZipScratch, fmt.Sprintf(base+".zip")); err != nil { + if err := tasks.uploadFile(ctx, servingFS, mod.ZipScratch, base+".zip"); err != nil { return err } if err := gcsfs.WriteFile(servingFS, base+".info", []byte(mod.Info)); err != nil {