-
Notifications
You must be signed in to change notification settings - Fork 265
Create a more attractive favicon.ico #129
Comments
I've been wanting to see this as well. Here are some mockups I threw together today. They're high-DPI-friendly and I'm just approximating the size for now: My personal preference is 1. I also wanted to improve the godoc badge. (Is that OK?) The current one is too small and fuzzy, making it hard to read. Here's a slightly larger, high-DPI version: But I don't see how black and green fits the GoDoc color scheme. I like this blue one better, and my preferred size is the middle one: What do you think about any of these? |
No.1 +1 |
@mholt Thanks for taking this on.
|
@mholt I like 1, but could we try "GO DOC" or "Go Doc" instead of "Go DOC"? I also quite like 5, and would be happy to go with that. |
@nf Using "Go Doc" instead of "Go DOC", and aligned slightly better inside the container: I initially made "DOC" capitalized for readability at a small size. I prefer "Go Doc" over "GO DOC", though, because the name of the language is usually seen cased as "Go". I'd also be okay with style 5. @nathany Good point about the iOS icons; I'm showing the rounded corners here because I think the favicon would look better rounded than square. (But that's just my opinion.) The final renderings for apple-touch-icons would be square so iOS can decide how to round them out. About the badge... I had no idea that shields.io was a thing. I have a few questions.
|
@mholt I think you've nailed it with your revised version of 1. I also think "godoc" is a term of art in the Go world, and so it should probably be used on the badge. |
Here's what the new one looks like on my retina display, compared with the current one: Here's the retina-ready badge along with the code in this post that displays it: <img width="120" alt="godoc" src="https://cloud.githubusercontent.com/assets/1128849/3086388/c474ec06-e531-11e3-9d8b-5cf09180d28a.png"> (Of course, we'd relocate the image and give it a permanent home.) We'd probably want to replace the current badge too? Here's one of the same approximate size as what we have now:
|
@mholt Nice work on the new favicon. Much improved. Do you have a non-Retina display to check it on or a url for others to see it in context? I did help get the Sheilds.io project organized a few months ago, but I haven't been involved recently.
|
@mholt I can take on the SVG badge if you prefer.
|
@nathany I have a non-retina display at work, here's a screenshot: As for the badge, and the left/right sides, I see that it's a key/value thing. Looking at Here's an SVG version (hosted from my windowsill temporarily because I can't find an SVG image host), but it renders quite poorly on GitHub as you can see (it's a little big, but this is just a sample): I'm sure there's a better way to display it? Either way, you're welcome to use Shields to generate an SVG. It'll look slightly different but might show up better. If not, I still personally lean toward using an img tag that we give people with a width specified to control the size. It looks sharp and is just as easy to copy+paste. I'll trust your judgment, though. Thanks for helping this move along! |
The non-retina version isn't too bad. Thanks for checking. Are you doing a PR just to update the favicon and touch icons? @mholt Which color (RGB/hex) are you using for the blue? |
Just picking a blue from the middle of the gradient: #5272B4 I'll submit a PR soon with the updated favicon and some square apple touch icons. iOS 7 and the latest versions of Safari don't add effects to the images so I won't be including the precomposed icons (unless you'd like them). For the badge, anything else you'd like from me going forward, maybe a PR to replace the existing non-retina badge (status.png)? |
I've been meaning to update the badge for a while... I'll take care of that one and then await your review. :-) Thanks. Is the blue the same dark blue as the buttons on http://golang.org/ ? Seems appropriate. The "reference" copy I'm not certain about. |
@nathany It's slightly lighter than the dark blue buttons; I felt it contrasted the dark gray better, but it doesn't matter to me. |
![GoDoc](http://img.shields.io/badge/godoc-reference-5272B4.svg) This is what the Read the Docs project for Python has: The goal with Shields is to have consistency across the badges that live in a README together. So I'd rather just use what they provide even if we could do something a little better by hand. Also, we can generate a new PNG for legacy non-Retina use: ![GoDoc](http://img.shields.io/badge/godoc-reference-5272B4.png) If we developed the scoring stuff (how is beyond me atm) it's just a matter of redirecting to a different badge. |
Cool, the blue SVG badge at the top looks pretty good. Even the blue PNG badge at the bottom is a decent replacement for what we have now. I'm still not sure how "godoc" is a key and "reference" is a value (what would the other values be?) - but it sure does read well as "godoc reference" -- so I'm good with it. |
@mholt I know what you mean. Mind you "godoc" for a value is about as appropriate in my mind. I'm sure we'll change it again at some point #171. There has also been talk of a flatter look in the future. travis-ci/travis-ci#630 (comment) |
@mholt How is that new icon coming? |
This is live now. |
Create a site icon that's more attractive than the one that I generated using an online favicon generator. Add apple-touch-icon-precomposed.png and apple-touch-icon.png variants of the icon.
The text was updated successfully, but these errors were encountered: