From ce7eed4960a200ae3109931fbb37e558d900569b Mon Sep 17 00:00:00 2001 From: Rob Findley Date: Fri, 6 Sep 2024 21:17:09 +0000 Subject: [PATCH] doc/generate: minor cleanup Remove the unused 'upperFirst' function, and fix a potential NPE due to an incorrect predicate. Change-Id: I671a3418b82ea77e5c9bb598f2be0b958078e464 Reviewed-on: https://go-review.googlesource.com/c/tools/+/611575 Reviewed-by: Alan Donovan LUCI-TryBot-Result: Go LUCI Auto-Submit: Robert Findley --- gopls/doc/generate/generate.go | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/gopls/doc/generate/generate.go b/gopls/doc/generate/generate.go index c55f5fc28b6..3fd3e58e6ed 100644 --- a/gopls/doc/generate/generate.go +++ b/gopls/doc/generate/generate.go @@ -452,7 +452,7 @@ func loadLenses(settingsPkg *packages.Package, defaults map[settings.CodeLensSou return nil, fmt.Errorf("%s: declare one CodeLensSource per line", posn) } lit, ok := spec.Values[0].(*ast.BasicLit) - if !ok && lit.Kind != token.STRING { + if !ok || lit.Kind != token.STRING { return nil, fmt.Errorf("%s: CodeLensSource value is not a string literal", posn) } value, _ := strconv.Unquote(lit.Value) // ignore error: AST is well-formed @@ -539,13 +539,6 @@ func lowerFirst(x string) string { return strings.ToLower(x[:1]) + x[1:] } -func upperFirst(x string) string { - if x == "" { - return x - } - return strings.ToUpper(x[:1]) + x[1:] -} - func fileForPos(pkg *packages.Package, pos token.Pos) (*ast.File, error) { fset := pkg.Fset for _, f := range pkg.Syntax {