From 2b8494a8d05fea085d9f2ce3e6d0f856528916a5 Mon Sep 17 00:00:00 2001 From: "Hana (Hyang-Ah) Kim" Date: Tue, 16 Jul 2024 13:38:57 -0400 Subject: [PATCH] extension/test/integration: skip broken install test for go1.19/1.20 For go 1.19 and 1.20, the extension installs old gopls https://github.com/golang/tools/tree/master/gopls#supported-go-versions For golang/vscode-go#3454 Change-Id: Ia72d3d9a21789404e80da1579d2fd85dfc633883 Reviewed-on: https://go-review.googlesource.com/c/vscode-go/+/598596 Commit-Queue: Hyang-Ah Hana Kim Reviewed-by: Hongxiang Jiang kokoro-CI: kokoro --- extension/test/integration/install.test.ts | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/extension/test/integration/install.test.ts b/extension/test/integration/install.test.ts index 9749371768..9e64854408 100644 --- a/extension/test/integration/install.test.ts +++ b/extension/test/integration/install.test.ts @@ -176,7 +176,12 @@ suite('Installation Tests', function () { } } - test('Install one tool with a local proxy', async () => { + test('Install one tool with a local proxy', async function () { + // TODO(golang/vscode-go#3454): reenable the test for old go. + const systemGoVersion = await getGoVersion(); + if (systemGoVersion.lt('1.21')) { + this.skip(); + } await runTest( [ {