Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vulndb: potential Go vuln in github.com/ipfs/go-merkledag: CVE-2022-23495 #1157

Closed
GoVulnBot opened this issue Dec 8, 2022 · 1 comment
Assignees

Comments

@GoVulnBot
Copy link

CVE-2022-23495 references github.com/ipfs/go-merkledag, which may be a Go module.

Description:
go-merkledag implements the 'DAGService' interface and adds two ipld node types, Protobuf and Raw for the ipfs project. A ProtoNode may be modified in such a way as to cause various encode errors which will trigger a panic on common method calls that don't allow for error returns. A ProtoNode should only be able to encode to valid DAG-PB, attempting to encode invalid DAG-PB forms will result in an error from the codec. Manipulation of an existing (newly created or decoded) ProtoNode using the modifier methods did not account for certain states that would place the ProtoNode into an unencodeable form. Due to conformance with the github.com/ipfs/go-block-format#Block and github.com/ipfs/go-ipld-format#Node interfaces, certain methods, which internally require a re-encode if state has changed, will panic due to the inability to return an error. This issue has been addressed across a number of pull requests. Users are advised to upgrade to version 0.8.1 for a complete set of fixes. Users unable to upgrade may attempt to mitigate this issue by sanitising inputs when allowing user-input to set a new CidBuilder on a ProtoNode and by sanitising Tsize (Link#Size) values such that they are a reasonable byte-size for sub-DAGs where derived from user-input.

References:

Cross references:
No existing reports found with this module or alias.

See doc/triage.md for instructions on how to triage this report.

modules:
  - module: github.com/ipfs/go-merkledag
    packages:
      - package: go-merkledag
description: |
    go-merkledag implements the 'DAGService' interface and adds two ipld node types, Protobuf and Raw for the ipfs project. A `ProtoNode` may be modified in such a way as to cause various encode errors which will trigger a panic on common method calls that don't allow for error returns. A `ProtoNode` should only be able to encode to valid DAG-PB, attempting to encode invalid DAG-PB forms will result in an error from the codec. Manipulation of an existing (newly created or decoded) `ProtoNode` using the modifier methods did not account for certain states that would place the `ProtoNode` into an unencodeable form. Due to conformance with the [`github.com/ipfs/go-block-format#Block`](https://pkg.go.dev/github.com/ipfs/go-block-format#Block) and [`github.com/ipfs/go-ipld-format#Node`](https://pkg.go.dev/github.com/ipfs/go-ipld-format#Node) interfaces, certain methods, which internally require a re-encode if state has changed, will panic due to the inability to return an error. This issue has been addressed across a number of pull requests. Users are advised to upgrade to version 0.8.1 for a complete set of fixes. Users unable to upgrade may attempt to mitigate this issue by sanitising inputs when allowing user-input to set a new `CidBuilder` on a `ProtoNode` and by sanitising `Tsize` (`Link#Size`) values such that they are a reasonable byte-size for sub-DAGs where derived from user-input.
cves:
  - CVE-2022-23495
references:
  - web: https://github.com/ipfs/go-merkledag/security/advisories/GHSA-x39j-h85h-3f46
  - web: https://github.com/ipfs/go-merkledag/issues/90
  - web: https://github.com/ipfs/kubo/issues/9297
  - fix: https://github.com/ipfs/go-merkledag/pull/91
  - fix: https://github.com/ipfs/go-merkledag/pull/92
  - fix: https://github.com/ipfs/go-merkledag/pull/93
  - web: https://en.wikipedia.org/wiki/Directed_acyclic_graph
  - web: https://github.com/ipfs/go-merkledag/releases/tag/v0.8.0
  - web: https://github.com/ipfs/go-merkledag/releases/tag/v0.8.1

@tatianab
Copy link
Contributor

Duplicate of #1155

@tatianab tatianab marked this as a duplicate of #1155 Dec 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants