Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vulndb: potential Go vuln in github.com/filecoin-project/lotus: GHSA-4g52-pqcj-phvh #1313

Closed
GoVulnBot opened this issue Jan 9, 2023 · 1 comment

Comments

@GoVulnBot
Copy link

In GitHub Security Advisory GHSA-4g52-pqcj-phvh, there is a vulnerability in the following Go packages or modules:

Unit Fixed Vulnerable Ranges
github.com/filecoin-project/lotus 1.5.0 < 1.5.0

Cross references:

See doc/triage.md for instructions on how to triage this report.

modules:
  - module: TODO
    versions:
      - fixed: 1.5.0
    packages:
      - package: github.com/filecoin-project/lotus
description: |-
    ### Impact

    1. BLS signature validation in lotus uses blst library method VerifyCompressed. This method accepts signatures in 2 forms - "serialized", and "compressed", meaning that BLS signatures can be provided as either of 2 unique byte arrays.
    2. Lotus block validation functions perform a uniqueness check on provided blocks. Two blocks are considered distinct if the CIDs of their blockheader do not match. The CID method for blockheader includes the BlockSig of the block.

    The result of these issues is that it would be possible to punish miners for valid blocks, as there are two different valid block CIDs available for each block, even though this must be unique.

    ### Patches

    By switching from the go based `blst` bindings over to the bindings in `filecoin-ffi`, the code paths now ensure that all signatures are compressed by size and the way they are deserialized.
    This happened in https://github.com/filecoin-project/lotus/pull/5393


    ### References

    - Original POC: https://gist.github.com/wadeAlexC/2490d522e81a796af9efcad1686e6754
cves:
  - CVE-2021-21405
ghsas:
  - GHSA-4g52-pqcj-phvh

@tatianab
Copy link
Contributor

tatianab commented Jan 9, 2023

Duplicate of #905

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants