Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

x/vulndb: potential Go vuln in github.com/sigstore/cosign: CVE-2022-35929 #758

Closed
GoVulnBot opened this issue Aug 4, 2022 · 3 comments
Assignees

Comments

@GoVulnBot
Copy link

CVE-2022-35929 references github.com/sigstore/cosign, which may be a Go module.

Description:
cosign is a container signing and verification utility. In versions prior to 1.10.1 cosign can report a false positive if any attestation exists. cosign verify-attestation used with the --type flag will report a false positive verification when there is at least one attestation with a valid signature and there are NO attestations of the type being verified (--type defaults to "custom"). This can happen when signing with a standard keypair and with "keyless" signing with Fulcio. This vulnerability can be reproduced with the distroless.dev/static@sha256:dd7614b5a12bc4d617b223c588b4e0c833402b8f4991fb5702ea83afad1986e2 image. This image has a vuln attestation but not an spdx attestation. However, if you run cosign verify-attestation --type=spdx on this image, it incorrectly succeeds. This issue has been addressed in version 1.10.1 of cosign. Users are advised to upgrade. There are no known workarounds for this issue.

Links:

See doc/triage.md for instructions on how to triage this report.

packages:
  - module: github.com/sigstore/cosign
    package: cosign
description: |
    cosign is a container signing and verification utility. In versions prior to 1.10.1 cosign can report a false positive if any attestation exists. `cosign verify-attestation` used with the `--type` flag will report a false positive verification when there is at least one attestation with a valid signature and there are NO attestations of the type being verified (--type defaults to "custom"). This can happen when signing with a standard keypair and with "keyless" signing with Fulcio. This vulnerability can be reproduced with the `distroless.dev/static@sha256:dd7614b5a12bc4d617b223c588b4e0c833402b8f4991fb5702ea83afad1986e2` image. This image has a `vuln` attestation but not an `spdx` attestation. However, if you run `cosign verify-attestation --type=spdx` on this image, it incorrectly succeeds. This issue has been addressed in version 1.10.1 of cosign. Users are advised to upgrade. There are no known workarounds for this issue.
cves:
  - CVE-2022-35929
links:
    commit: https://github.com/sigstore/cosign/commit/c5fda01a8ff33ca981f45a9f13e7fb6bd2080b94
    context:
      - https://github.com/sigstore/cosign/security/advisories/GHSA-vjxv-45g9-9296

@rolandshoemaker
Copy link
Member

Vuln in importable package which is only used by the parent tool.

@neild neild added excluded: EFFECTIVELY_PRIVATE This vulnerability exists in a package can be imported, but isn't meant to be outside that module. and removed NotGoVuln labels Aug 10, 2022
@zpavlinovic zpavlinovic self-assigned this Nov 8, 2023
@zpavlinovic zpavlinovic added NeedsReport and removed excluded: EFFECTIVELY_PRIVATE This vulnerability exists in a package can be imported, but isn't meant to be outside that module. labels Nov 8, 2023
@zpavlinovic
Copy link
Contributor

The package has a few importers and some related packages have more. To be safe, we now create a report for this package.

@zpavlinovic zpavlinovic reopened this Nov 8, 2023
@gopherbot
Copy link
Contributor

Change https://go.dev/cl/540935 mentions this issue: data/reports: add GO-2022-0758.yaml

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants