Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting a start and end range dynamically #5538

Closed
sergexte opened this issue Feb 20, 2019 · 2 comments
Closed

Setting a start and end range dynamically #5538

sergexte opened this issue Feb 20, 2019 · 2 comments
Assignees

Comments

@sergexte
Copy link

I have a UI that has two sliders which represent the start and end time of a segment of a video. The start and end time are set so that the video loops over the selected segment.
To implement this I tried doing making a Clipping source wrapped in a LoopingMediaSource. It works well when loaded the first time but the sliders on the UI are meant to be changed to loop the video in a dynamically set range. I have a callback every time the start or end times change where I stop the player, build the media source giving a ClippingMediaSource the new start and end times and wrap it in a LoopingMediaSource and then calling player.prepare() with the new source. However I can't make the experience be smooth since the callback is called as the slider is being moved. Each time I am stopping the player and calling prepare on it. Is there any recommended way of doing this?

@tonihei
Copy link
Collaborator

tonihei commented Feb 26, 2019

Duplicate of #3163

@tonihei tonihei marked this as a duplicate of #3163 Feb 26, 2019
@tonihei tonihei closed this as completed Feb 26, 2019
@tonihei
Copy link
Collaborator

tonihei commented Feb 26, 2019

We are working on supporting this feature and it should be part of the upcoming 2.10 release.

@google google locked and limited conversation to collaborators Aug 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants