DefaultDrmSessionManager and OfflineLicenseHelper does a DRM leak

[sharish]

This is more of a code review than an issue where FrameworkMediaDrm getting initialized through static factory methods does not have a way to release the MediaDrm.

ExoPlayer/library/core/src/main/java/com/google/android/exoplayer2/drm/DefaultDrmSessionManager.java

Line 161 in 1ab402c

FrameworkMediaDrm.newInstance(uuid),

ExoPlayer/library/core/src/main/java/com/google/android/exoplayer2/drm/OfflineLicenseHelper.java

Line 104 in 1ab402c

FrameworkMediaDrm.newInstance(C.WIDEVINE_UUID),

Initializing too many DefaultSessionManager|OfflineLicenseHelper this way end up throwing the following exception. Once this failure happen, any media from any application dependent on DRM fails to play the video. It's hard to figure out which application caused this DRM leak as well.

android.media.MediaCodec$CodecException: Error 0x80000000
at android.media.MediaCodec.native_dequeueOutputBuffer(Native Method)
at android.media.MediaCodec.dequeueOutputBuffer(MediaCodec.java:2752)
at com.google.android.exoplayer2.mediacodec.MediaCodecRenderer.drainOutputBuffer(MediaCodecRenderer.java:1427)
at com.google.android.exoplayer2.mediacodec.MediaCodecRenderer.render(MediaCodecRenderer.java:654)
at com.google.android.exoplayer2.ExoPlayerImplInternal.doSomeWork(ExoPlayerImplInternal.java:575)
at com.google.android.exoplayer2.ExoPlayerImplInternal.handleMessage(ExoPlayerImplInternal.java:326)
at android.os.Handler.dispatchMessage(Handler.java:102)
at android.os.Looper.loop(Looper.java:209)
at android.os.HandlerThread.run(HandlerThread.java:67)

[google-oss-bot]

This issue does not seem to follow the issue template. Make sure you provide all the required information.

[ojw28]

Duplicate of #4721