diff --git a/android/guava/src/com/google/common/collect/CompactHashSet.java b/android/guava/src/com/google/common/collect/CompactHashSet.java index b90c678c030b..d1073b5fcbd1 100644 --- a/android/guava/src/com/google/common/collect/CompactHashSet.java +++ b/android/guava/src/com/google/common/collect/CompactHashSet.java @@ -104,7 +104,6 @@ class CompactHashSet extends AbstractSet implemen * @return a new {@code CompactHashSet} containing those elements (minus duplicates) */ @SafeVarargs - @SuppressWarnings("nullness") // TODO: b/316358623 - Remove after checker fix. public static CompactHashSet create(E... elements) { CompactHashSet set = createWithExpectedSize(elements.length); Collections.addAll(set, elements); diff --git a/android/guava/src/com/google/common/collect/CompactLinkedHashSet.java b/android/guava/src/com/google/common/collect/CompactLinkedHashSet.java index b5c554fc47b6..21d48058ad72 100644 --- a/android/guava/src/com/google/common/collect/CompactLinkedHashSet.java +++ b/android/guava/src/com/google/common/collect/CompactLinkedHashSet.java @@ -79,7 +79,6 @@ class CompactLinkedHashSet extends CompactHashSet * @return a new {@code CompactLinkedHashSet} containing those elements (minus duplicates) */ @SafeVarargs - @SuppressWarnings("nullness") // TODO: b/316358623 - Remove after checker fix. public static CompactLinkedHashSet create(E... elements) { CompactLinkedHashSet set = createWithExpectedSize(elements.length); Collections.addAll(set, elements); diff --git a/android/guava/src/com/google/common/collect/ImmutableSortedMap.java b/android/guava/src/com/google/common/collect/ImmutableSortedMap.java index bccc8a074afb..42e9cffa729b 100644 --- a/android/guava/src/com/google/common/collect/ImmutableSortedMap.java +++ b/android/guava/src/com/google/common/collect/ImmutableSortedMap.java @@ -494,7 +494,6 @@ private static ImmutableSortedMap fromEntries( return fromEntries(comparator, sameComparator, entryArray, entryArray.length); } - @SuppressWarnings("nullness") // TODO: b/316358623 - Remove after checker fix. private static ImmutableSortedMap fromEntries( final Comparator comparator, boolean sameComparator, diff --git a/android/guava/src/com/google/common/collect/Lists.java b/android/guava/src/com/google/common/collect/Lists.java index 9846cd282aac..327a2004975f 100644 --- a/android/guava/src/com/google/common/collect/Lists.java +++ b/android/guava/src/com/google/common/collect/Lists.java @@ -100,7 +100,6 @@ private Lists() {} */ @SafeVarargs @GwtCompatible(serializable = true) - @SuppressWarnings("nullness") // TODO: b/316358623 - Remove after checker fix. public static ArrayList newArrayList(E... elements) { checkNotNull(elements); // for GWT // Avoid integer overflow when a large array is passed in diff --git a/android/guava/src/com/google/common/collect/Ordering.java b/android/guava/src/com/google/common/collect/Ordering.java index 6483ebfc06de..1182274e6737 100644 --- a/android/guava/src/com/google/common/collect/Ordering.java +++ b/android/guava/src/com/google/common/collect/Ordering.java @@ -747,7 +747,6 @@ public E max( * @throws IllegalArgumentException if {@code k} is negative * @since 8.0 */ - @SuppressWarnings("nullness") // TODO: b/316358623 - Remove after checker fix. public List leastOf(Iterable iterable, int k) { if (iterable instanceof Collection) { Collection collection = (Collection) iterable; @@ -864,7 +863,6 @@ public List greatestOf(Iterator iterator, int k) { * calling {@link Collections#sort(List)}. */ // TODO(kevinb): rerun benchmarks including new options - @SuppressWarnings("nullness") // TODO: b/316358623 - Remove after checker fix. public List sortedCopy(Iterable elements) { @SuppressWarnings("unchecked") // does not escape, and contains only E's E[] array = (E[]) Iterables.toArray(elements); diff --git a/android/guava/src/com/google/common/collect/Sets.java b/android/guava/src/com/google/common/collect/Sets.java index 0cecc57cf84a..a92d608a2094 100644 --- a/android/guava/src/com/google/common/collect/Sets.java +++ b/android/guava/src/com/google/common/collect/Sets.java @@ -196,7 +196,6 @@ public static > EnumSet newEnumSet( * asList}{@code (...))}, or for creating an empty set then calling {@link Collections#addAll}. * This method is not actually very useful and will likely be deprecated in the future. */ - @SuppressWarnings("nullness") // TODO: b/316358623 - Remove after checker fix. public static HashSet newHashSet(E... elements) { HashSet set = newHashSetWithExpectedSize(elements.length); Collections.addAll(set, elements); diff --git a/android/guava/src/com/google/common/collect/TopKSelector.java b/android/guava/src/com/google/common/collect/TopKSelector.java index 9db4d6b96dd5..4207aa3e354b 100644 --- a/android/guava/src/com/google/common/collect/TopKSelector.java +++ b/android/guava/src/com/google/common/collect/TopKSelector.java @@ -160,7 +160,6 @@ public void offer(@ParametricNullness T elem) { * Quickselects the top k elements from the 2k elements in the buffer. O(k) expected time, O(k log * k) worst case. */ - @SuppressWarnings("nullness") // TODO: b/316358623 - Remove after checker fix. private void trim() { int left = 0; int right = 2 * k - 1; @@ -273,7 +272,6 @@ public void offerAll(Iterator elements) { *

The returned list is an unmodifiable copy and will not be affected by further changes to * this {@code TopKSelector}. This method returns in O(k log k) time. */ - @SuppressWarnings("nullness") // TODO: b/316358623 - Remove after checker fix. public List topK() { @SuppressWarnings("nullness") // safe because we pass sort() a range that contains real Ts T[] castBuffer = (T[]) buffer; diff --git a/guava/src/com/google/common/collect/CompactHashSet.java b/guava/src/com/google/common/collect/CompactHashSet.java index 15d502111b5c..33c4c0a4d7eb 100644 --- a/guava/src/com/google/common/collect/CompactHashSet.java +++ b/guava/src/com/google/common/collect/CompactHashSet.java @@ -108,7 +108,6 @@ class CompactHashSet extends AbstractSet implemen * @return a new {@code CompactHashSet} containing those elements (minus duplicates) */ @SafeVarargs - @SuppressWarnings("nullness") // TODO: b/316358623 - Remove after checker fix. public static CompactHashSet create(E... elements) { CompactHashSet set = createWithExpectedSize(elements.length); Collections.addAll(set, elements); diff --git a/guava/src/com/google/common/collect/CompactLinkedHashSet.java b/guava/src/com/google/common/collect/CompactLinkedHashSet.java index 8a9284265261..c1d813cdb435 100644 --- a/guava/src/com/google/common/collect/CompactLinkedHashSet.java +++ b/guava/src/com/google/common/collect/CompactLinkedHashSet.java @@ -81,7 +81,6 @@ class CompactLinkedHashSet extends CompactHashSet * @return a new {@code CompactLinkedHashSet} containing those elements (minus duplicates) */ @SafeVarargs - @SuppressWarnings("nullness") // TODO: b/316358623 - Remove after checker fix. public static CompactLinkedHashSet create(E... elements) { CompactLinkedHashSet set = createWithExpectedSize(elements.length); Collections.addAll(set, elements); diff --git a/guava/src/com/google/common/collect/ImmutableSortedMap.java b/guava/src/com/google/common/collect/ImmutableSortedMap.java index bf9f70f8cd2e..495cb23dd5f1 100644 --- a/guava/src/com/google/common/collect/ImmutableSortedMap.java +++ b/guava/src/com/google/common/collect/ImmutableSortedMap.java @@ -493,7 +493,6 @@ private static ImmutableSortedMap fromEntries( return fromEntries(comparator, sameComparator, entryArray, entryArray.length); } - @SuppressWarnings("nullness") // TODO: b/316358623 - Remove after checker fix. private static ImmutableSortedMap fromEntries( final Comparator comparator, boolean sameComparator, diff --git a/guava/src/com/google/common/collect/Lists.java b/guava/src/com/google/common/collect/Lists.java index d6af57d0313a..7bf9949a3029 100644 --- a/guava/src/com/google/common/collect/Lists.java +++ b/guava/src/com/google/common/collect/Lists.java @@ -101,7 +101,6 @@ private Lists() {} */ @SafeVarargs @GwtCompatible(serializable = true) - @SuppressWarnings("nullness") // TODO: b/316358623 - Remove after checker fix. public static ArrayList newArrayList(E... elements) { checkNotNull(elements); // for GWT // Avoid integer overflow when a large array is passed in diff --git a/guava/src/com/google/common/collect/Ordering.java b/guava/src/com/google/common/collect/Ordering.java index 6483ebfc06de..1182274e6737 100644 --- a/guava/src/com/google/common/collect/Ordering.java +++ b/guava/src/com/google/common/collect/Ordering.java @@ -747,7 +747,6 @@ public E max( * @throws IllegalArgumentException if {@code k} is negative * @since 8.0 */ - @SuppressWarnings("nullness") // TODO: b/316358623 - Remove after checker fix. public List leastOf(Iterable iterable, int k) { if (iterable instanceof Collection) { Collection collection = (Collection) iterable; @@ -864,7 +863,6 @@ public List greatestOf(Iterator iterator, int k) { * calling {@link Collections#sort(List)}. */ // TODO(kevinb): rerun benchmarks including new options - @SuppressWarnings("nullness") // TODO: b/316358623 - Remove after checker fix. public List sortedCopy(Iterable elements) { @SuppressWarnings("unchecked") // does not escape, and contains only E's E[] array = (E[]) Iterables.toArray(elements); diff --git a/guava/src/com/google/common/collect/Sets.java b/guava/src/com/google/common/collect/Sets.java index d46bc06715b3..520acc6bf237 100644 --- a/guava/src/com/google/common/collect/Sets.java +++ b/guava/src/com/google/common/collect/Sets.java @@ -196,7 +196,6 @@ public static > EnumSet newEnumSet( * asList}{@code (...))}, or for creating an empty set then calling {@link Collections#addAll}. * This method is not actually very useful and will likely be deprecated in the future. */ - @SuppressWarnings("nullness") // TODO: b/316358623 - Remove after checker fix. public static HashSet newHashSet(E... elements) { HashSet set = newHashSetWithExpectedSize(elements.length); Collections.addAll(set, elements); diff --git a/guava/src/com/google/common/collect/TopKSelector.java b/guava/src/com/google/common/collect/TopKSelector.java index 24d7679af39d..9cd335ee6260 100644 --- a/guava/src/com/google/common/collect/TopKSelector.java +++ b/guava/src/com/google/common/collect/TopKSelector.java @@ -161,7 +161,6 @@ public void offer(@ParametricNullness T elem) { * Quickselects the top k elements from the 2k elements in the buffer. O(k) expected time, O(k log * k) worst case. */ - @SuppressWarnings("nullness") // TODO: b/316358623 - Remove after checker fix. private void trim() { int left = 0; int right = 2 * k - 1; @@ -274,7 +273,6 @@ public void offerAll(Iterator elements) { *

The returned list is an unmodifiable copy and will not be affected by further changes to * this {@code TopKSelector}. This method returns in O(k log k) time. */ - @SuppressWarnings("nullness") // TODO: b/316358623 - Remove after checker fix. public List topK() { @SuppressWarnings("nullness") // safe because we pass sort() a range that contains real Ts T[] castBuffer = (T[]) buffer;