Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bundle-SymbolicName of guice-assistedinject 5.0.0 is broken and has the same name as guice #1496

Closed
AndreasTu opened this issue Feb 26, 2021 · 3 comments

Comments

@AndreasTu
Copy link

In the guice-assistedinject version 5.0.0 the Bundle-SymbolicName in the Manifest.MF is broken.
The old name in 4.2.3 was com.google.inject.assistedinject now in 5.0 it is com.google.inject, but this is the same name as the main Guice Bundle-SymbolicName.

This leads to the fact that the Eclipse-Runtime refuses to activate the main guice, when also the guice-assistedinject is present, because it assumes it is a fragment.

Expected:
The guice-assistedinject shall have Bundle-SymbolicName: com.google.inject.assistedinject in the Manifest.MF

@ad-fu
Copy link
Collaborator

ad-fu commented Feb 26, 2021

Some files were deleted between the beta and final cut, which affected the generated Manifest.MF. Will send out 5.0.1 to fix this.

@markmarch
Copy link
Contributor

Fixed in 5.0.1 with #1499.

@AndreasTu
Copy link
Author

It works. Thank you for the change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants