Grapher generates dot files with syntax errors

[gissuebot]

From stantonk on June 19, 2013 15:54:36

Description of the issue: Grapher generates dot files with syntax errors:

Warning: graph.dot:3: syntax error in line 3 near ',' Steps to reproduce: 1. Follow the example https://code.google.com/p/google-guice/wiki/Grapher 2. Run the code
3. Try to generate a diagram using dot, e.g.

  dot -Tsvg graph.dot > graph.svg

Original issue: http://code.google.com/p/google-guice/issues/detail?id=755

[gissuebot]

From sberlin on December 05, 2013 14:51:25

Patches are gladly accepted!

[gissuebot]

From scott.macgibbon on December 20, 2013 08:50:29

I get the same error - any clue on how to get a correct graph generated?

[gissuebot]

From scot.hale on December 26, 2013 11:44:34

This is what I did to get it to work with guice 4.x: http://stackoverflow.com/questions/9301007/is-there-any-way-to-get-guice-grapher-to-work/20790253#20790253

[gissuebot]

From sberlin on December 26, 2013 11:48:55

If there's something we can change in the code itself to fix this, please attach a patch here.  Thanks!

[gissuebot]

From tavianator on January 06, 2014 00:04:18

The attached patch is all that's necessary to get a simple example working for me.  I wasn't sure how to right a good test that captured this fix.  Perhaps an integration test should actually invoke dot to check the syntax of a generated file?

Attachment: gist
   0001-extensions-grapher-Fix-a-syntax-error-in-the-generat.patch

[gissuebot]

From tavianator on March 25, 2014 10:53:17

Ping?

[gissuebot]

From sberlin on April 10, 2014 16:28:44

Fixed by r=647b24f7f1b5.

Status: Fixed