Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup the symbols to have new names #158

Open
mithro opened this issue Sep 30, 2020 · 2 comments
Open

Cleanup the symbols to have new names #158

mithro opened this issue Sep 30, 2020 · 2 comments
Labels
documentation Improvements or additions to documentation files-symbol-svg Issues related to symbol files.

Comments

@mithro
Copy link
Contributor

mithro commented Sep 30, 2020

The pull request at #157 added the primitive models. A lot of the symbols images that were added still use the old non-SKY130 names. Specific examples are the diodes. These should be cleaned up and made to match the new names.

@mithro mithro added documentation Improvements or additions to documentation files-symbol-svg Issues related to symbol files. lib-sky130_fd_pr_base labels Sep 30, 2020
@diadatp
Copy link
Contributor

diadatp commented Nov 12, 2020

The symbol SVGs look like wrappers around PNGs with a few references to Inkscape(?), some invisible bullet point shape paths and glyphs for a font. I'm assuming the corrected symbols will be a complete replacement.

@StefanSchippers has created most of the required symbols and shared them here. Xschem has the ability to perform SVG exports. I've attached PNG versions as a preview. They differ from the SVG versions in the way the text is rendered. If the style is fine then the work of completing the set and generating them to the correct size can go forward.

res_iso_pw
pfet_01v8

@StefanSchippers
Copy link

Device names should be definitely cleaned up in the 'Device Details' web page.
We have too generic cell names like
'diode'
to overly complex cell names like
'sky130_fd_pr__cap_vpp_XXpXxYYpY_{MM}(_shield(SS))(_float(FF))'
I have no problem changing the names. Information about Diodes in particular should be cleaned up.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation files-symbol-svg Issues related to symbol files.
Projects
None yet
Development

No branches or pull requests

3 participants