Skip to content
This repository has been archived by the owner on Jun 28, 2022. It is now read-only.

Generated code doesn't have 100% coverage #2398

Closed
crwilcox opened this issue Nov 1, 2018 · 2 comments
Closed

Generated code doesn't have 100% coverage #2398

crwilcox opened this issue Nov 1, 2018 · 2 comments
Assignees
Labels
lang: python Issues specific to Python.

Comments

@crwilcox
Copy link

crwilcox commented Nov 1, 2018

googleapis/google-cloud-python#6356 (diff)

This code (securitycenter, python) doesn't have full coverage which seems unusual.

ox > coverage report --show-missing --fail-under=100
Name                                                                                     Stmts   Miss  Cover   Missing
----------------------------------------------------------------------------------------------------------------------
google/cloud/securitycenter_v1beta1/__init__.py                                              8      0   100%
google/cloud/securitycenter_v1beta1/gapic/__init__.py                                        0      0   100%
google/cloud/securitycenter_v1beta1/gapic/enums.py                                          23      0   100%
google/cloud/securitycenter_v1beta1/gapic/security_center_client.py                        163      9    94%   78-81, 123, 178-189
google/cloud/securitycenter_v1beta1/gapic/security_center_client_config.py                   1      0   100%
google/cloud/securitycenter_v1beta1/gapic/transports/__init__.py                             0      0   100%
google/cloud/securitycenter_v1beta1/gapic/transports/security_center_grpc_transport.py      51      3    94%   55, 61, 96
google/cloud/securitycenter_v1beta1/proto/__init__.py                                        0      0   100%
google/cloud/securitycenter_v1beta1/proto/asset_pb2.py                                      34      0   100%
google/cloud/securitycenter_v1beta1/proto/asset_pb2_grpc.py                                  1      1     0%   2
google/cloud/securitycenter_v1beta1/proto/finding_pb2.py                                    34      0   100%
google/cloud/securitycenter_v1beta1/proto/finding_pb2_grpc.py                                1      1     0%   2
google/cloud/securitycenter_v1beta1/proto/organization_settings_pb2.py                      25      0   100%
google/cloud/securitycenter_v1beta1/proto/organization_settings_pb2_grpc.py                  1      1     0%   2
google/cloud/securitycenter_v1beta1/proto/security_marks_pb2.py                             23      0   100%
google/cloud/securitycenter_v1beta1/proto/security_marks_pb2_grpc.py                         1      1     0%   2
google/cloud/securitycenter_v1beta1/proto/securitycenter_service_pb2.py                    158      0   100%
google/cloud/securitycenter_v1beta1/proto/securitycenter_service_pb2_grpc.py               106     57    46%   123-125, 131-133, 138-140, 145-147, 152-154, 160-162, 171-173, 178-180, 188-190, 195-197, 207-209, 214-216, 221-223, 228-230, 236-238, 243-245, 250-252, 257-259, 263-357
google/cloud/securitycenter_v1beta1/proto/source_pb2.py                                     17      0   100%
google/cloud/securitycenter_v1beta1/proto/source_pb2_grpc.py                                 1      1     0%   2
google/cloud/securitycenter_v1beta1/types.py                                                34      0   100%
----------------------------------------------------------------------------------------------------------------------
TOTAL                                                                                      682     74    89%
@tseaver
Copy link
Contributor

tseaver commented Nov 1, 2018

Most autogen-only libs have a .coveragerc which looks like:

[run]
branch = True

[report]
fail_under = 100
show_missing = True
exclude_lines =
    # Re-enable the standard pragma
    pragma: NO COVER
    # Ignore debug-only repr
    def __repr__
omit =
  */gapic/*
  */proto/*

@crwilcox
Copy link
Author

crwilcox commented Nov 1, 2018

that was the issue. closing.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lang: python Issues specific to Python.
Projects
None yet
Development

No branches or pull requests

2 participants